Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1501] Create Unit Tests for FeedbackConstantSumQuestionDetails class #12402

Merged
merged 4 commits into from
Apr 23, 2023
Merged

[#1501] Create Unit Tests for FeedbackConstantSumQuestionDetails class #12402

merged 4 commits into from
Apr 23, 2023

Conversation

landa44
Copy link
Contributor

@landa44 landa44 commented Apr 21, 2023 •
edited by jasonqiu212
Loading

Part of #1501

Outline of Solution

I added a few tests to cover testValidateQuestionDetails method from FeedbackConstantSumQuestionDetails class.

@github-actions
Copy link

Hi @landa44, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

@landa44 landa44 changed the title [ #1501] Create Unit Tests for FeedbackConstantSumQuestionDetails class [#1501] Create Unit Tests for FeedbackConstantSumQuestionDetails class Apr 21, 2023
jasonqiu212
jasonqiu212 approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasonqiu212 jasonqiu212 added the s.FinalReview The PR is ready for final review label Apr 21, 2023
zhaojj2209
zhaojj2209 approved these changes Apr 23, 2023
View reviewed changes
Copy link
Contributor

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaojj2209 zhaojj2209 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Apr 23, 2023
@zhaojj2209 zhaojj2209 merged commit a4b2777 into TEAMMATES:master Apr 23, 2023
@samuelfangjw samuelfangjw added the c.Task Other non-user-facing works, e.g. refactoring, adding tests label Jul 14, 2023
@samuelfangjw samuelfangjw added this to the V8.28.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaojj2209 zhaojj2209 zhaojj2209 approved these changes

@jasonqiu212 jasonqiu212 jasonqiu212 approved these changes

Assignees

@jasonqiu212 jasonqiu212

@zhaojj2209 zhaojj2209

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.28.0
Development

Successfully merging this pull request may close these issues.
4 participants
@landa44 @jasonqiu212 @zhaojj2209 @samuelfangjw